GraphQL changes for 2.0 #3388
GraphQL changes for 2.0 #3388
Conversation
Rakefile
Outdated
| @@ -88,7 +88,7 @@ TEST_METADATA = { | |||
| 'graphql-2.1' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | |||
| 'graphql-2.0' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | |||
| 'graphql-1.13' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | |||
| 'graphql-1.12' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | |||
| # 'graphql-1.12' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | |||
There was a problem hiding this comment.
We can just remove the line if we are dropping support for graphql 1.12.
Rakefile
Outdated
| 'graphql-2.1' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | ||
| 'graphql-2.0' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | ||
| 'graphql-1.13' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', | ||
| 'graphql-1.12' => '❌ 2.1 / ❌ 2.2 / ❌ 2.3 / ❌ 2.4 / ❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ❌ 3.2 / ❌ 3.3 / ❌ jruby', |
There was a problem hiding this comment.
This is surprising -- why can't we test graphql on other Ruby versions? 🤔 👀
There was a problem hiding this comment.
Our 2.0 release contains breaking changes that makes existing graphql-ruby code not functional
There was a problem hiding this comment.
This matrix is for Ruby versions. I don't quite understand the connection between our graphql changes and why is it ok to test with Ruby 3.1, but not 3.2 or 2.7?
There was a problem hiding this comment.
I was using 3.1 as an example and will update the matrix with other Ruby versions once the changes are confirmed.
Also, the dependency should not be installing from my fork but the official gem release. 😄
There was a problem hiding this comment.
Got it -- thanks for clarifying 🙇
…multiple test cases
TonyCTHsu
force-pushed
the
tonycthsu/graphql-breaking-changes
branch
from
6d5ecf9
to
ae1ec81
Compare
2.0 Upgrade Guide notes
🚨 Breaking changes:
No longer support and patch GraphQL's defined-based schema
Support
graphql-rubyversions containing breaking changes.span_typechange to 1.13.x rmosolgo/graphql-ruby#4788span_typechange to 2.0.x rmosolgo/graphql-ruby#4789span_typechange to 2.1.x rmosolgo/graphql-ruby#4786span_typemethod call on SpanOperation rmosolgo/graphql-ruby#4776schemasoption defaultBefore: Your application's GraphQL schemas have to be explicitly provided through
schemasoption to be instrumented.Now: GraphQL
schemasis no longer required to be explicitly provided toschemasoption. By default, every schema is instrumented.Note: 1.13.x is only partially support(only class-based schema)
Note: Integration supported versions will be updated once
graphql-rubyreleases our patchNote: Doc will be updated once
graphql-rubyreleases our patch